address PR comments

codeready-toolchain · Sep 18, 2023 · 84f32f2 · 84f32f2
1 parent b6c8033
commit 84f32f2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/api/v1alpha1/workspace_types.go b/api/v1alpha1/workspace_types.go
@@ -41,6 +41,7 @@ type WorkspaceStatus struct {
 
 type Binding struct {
 	// MasterUserRecord is the name of the user that has access to the workspace.
+	// This field is immutable via a validating webhook.
 	MasterUserRecord string `json:"masterUserRecord,omitempty"`
 
 	// Role is the role of the user in the current workspace. For example "admin" for the user that has all permissions on the current workspace.
@@ -50,7 +51,7 @@ type Binding struct {
 	// Available values:
 	// - "update" when the role in the current binding can be changed
 	// - "delete" when the current binding can be deleted
-	// - "override" when the current binding can be overwritten by a new binding containing the same MasterUserRecord but a different role
+	// - "override" when the current binding is inherited from a parent workspace, it cannot be updated, but it can be overridden by creating a new binding containing the same MasterUserRecord but different role in the subworkspace.
 	// +listType=atomic
 	// +optional
 	AvailableActions []string `json:"availableActions,omitempty"`

diff --git a/api/v1alpha1/zz_generated.openapi.go b/api/v1alpha1/zz_generated.openapi.go