Merge pull request #9098 from kenjis/phpdoc-BaseModel

docs: fix `@return` type in BaseModel
codeigniter4 · Aug 2, 2024 · 6617533 · 6617533
2 parents ed1dfda + ae63cb4
commit 6617533
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -103,12 +103,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/BaseModel.php',
 ];
-$ignoreErrors[] = [
-	// identifier: missingType.iterableValue
-	'message' => '#^Method CodeIgniter\\\\BaseModel\\:\\:doErrors\\(\\) return type has no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/BaseModel.php',
-];
 $ignoreErrors[] = [
 	// identifier: missingType.iterableValue
 	'message' => '#^Method CodeIgniter\\\\BaseModel\\:\\:doFind\\(\\) has parameter \\$id with no value type specified in iterable type array\\.$#',

diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -541,7 +541,7 @@ abstract protected function doReplace(?array $row = null, bool $returnSQL = fals
      * Grabs the last error(s) that occurred from the Database connection.
      * This method works only with dbCalls.
      *
-     * @return array|null
+     * @return array<string, string>
      */
     abstract protected function doErrors();
 
@@ -1242,7 +1242,7 @@ public function replace(?array $row = null, bool $returnSQL = false)
      *
      * @param bool $forceDB Always grab the db error, not validation
      *
-     * @return array<string,string>
+     * @return array<string, string>
      */
     public function errors(bool $forceDB = false)
     {