Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

Update ExposureNotification binding #142

Conversation

keiji
Copy link
Collaborator

@keiji keiji commented May 2, 2021

Note
Version 19.7.2-eap-alpha03 is not officeial release.
This library based on Android Exposure Notifications SDK version 1.8.3-eap.

Version 1.2.3-alpha01 is not officeial release.
This library based on iOS 14.4 Exposure Notifications API.

Issue 番号 / Issue ID

目的 / Purpose

Xamarin.GooglePlayServices.Nearby.ExposureNotificationとXamarin.iOS.ExposureNotificationを更新する。

破壊的変更をもたらしますか / Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request の種類 / Pull Request type

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

検証方法 / How to test

コードの入手 / Get the code

git clone [repo-address]
cd [repo-name]
gh pr [pr-id]
dotnet restore

コードの検証 / Test the code

作成したNuGetパッケージをTempNugetFeedディレクトリに配置して、Nuget.configで指定することで読み込んでいる。

確認事項 / What to check

Exposure Notification機能の根幹となるライブラリを更新しているため、陽性登録と接触確認についてリグレッションテストが必要。

その他 / Other information

@keiji keiji self-assigned this May 2, 2021
@keiji keiji changed the base branch from master to develop June 7, 2021 07:19
@keiji keiji force-pushed the update_google_en_sdk_version_19-7-2-eap-alpha02 branch from 587d958 to fe9290b Compare July 10, 2021 03:20
@keiji keiji changed the title Update Google ExposureNotification library version to 19.7.2-eap-alpha02 Update Google ExposureNotification library version to 19.7.2-eap-alpha03 Jul 10, 2021
@keiji keiji force-pushed the update_google_en_sdk_version_19-7-2-eap-alpha02 branch from eefa60c to 24cfe76 Compare July 10, 2021 05:04
@@ -43,7 +43,7 @@ jobs:
run: msbuild ${{ github.workspace }}/Covid19Radar/Covid19Radar.Android/Covid19Radar.Android.csproj /restore /t:Build /p:Configuration=${{ matrix.Configuration }}
test:
name: Test
runs-on: ubuntu-latest
runs-on: macos-latest # Tests must be executed on macos
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ローカルにNuGetパッケージを置くとテストが通らなくなって困ったけど、実験を繰り返した結果、プラットフォームをmacosにしたら動くことがわかった。

https://github.com/keiji/cocoa/runs/3034626142
https://github.com/keiji/cocoa/runs/3035372919

@keiji keiji changed the title Update Google ExposureNotification library version to 19.7.2-eap-alpha03 Update ExposureNotification libraries version Jul 10, 2021
@keiji keiji changed the title Update ExposureNotification libraries version Update ExposureNotification binding Jul 10, 2021
@keiji keiji added the waiting-for-confirmation 関係者に確認中のもの label Jul 10, 2021
@keiji
Copy link
Collaborator Author

keiji commented Jul 12, 2021

TempNugetFeedのNuGet packagesを、GitHub Actionsで生成したものに差し替えた。

https://github.com/keiji/XamarinComponents/actions/runs/1023760504
https://github.com/keiji/XamarinComponents/actions/runs/1023760512

@keiji keiji requested a review from cocoa-dev July 13, 2021 16:59
@keiji keiji removed the waiting-for-confirmation 関係者に確認中のもの label Jul 16, 2021
@keiji keiji force-pushed the update_google_en_sdk_version_19-7-2-eap-alpha02 branch from 5cd5e07 to 17ac65f Compare August 5, 2021 07:31
@keiji
Copy link
Collaborator Author

keiji commented Aug 5, 2021

rebased

@keiji keiji mentioned this pull request Aug 5, 2021
@keiji
Copy link
Collaborator Author

keiji commented Aug 20, 2021

feature/cocoa2 で作業したものを develop 向けにPull Requestを出すという方針で進めています。
こちらのPull Requestはcloseします。

@keiji keiji closed this Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant