lib: Add onlyDirectories option to FileAutoComplete #20777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to use this in cockpit-project/cockpit-machines#1730 |
|
We can also add a option to fslist1 to filter before sending it. That might potentially save a lot of data traffic if people hit a massive directory but are not actually interested in the files in there. |
I would do that in |
jelly
approved these changes
Jul 19, 2024
cockpituous
reviewed
Jul 19, 2024
| @@ -117,7 +117,8 @@ export class FileAutoComplete extends React.Component { | |||
|
|
|||
| channel.addEventListener("message", (ev, data) => { | |||
| const item = JSON.parse(data); | |||
| if (item && item.path && item.event == 'present') { | |||
| if (item && item.path && item.event == 'present' && | |||
| (!this.props.onlyDirectories || item.type == 'directory')) { | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.