storage: Don't offer to mount while formatting in Anaconda mode #19807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
storage-no-anaconda-mounting
branch
from
25b3bc2
to
4bbc74c
Compare
mvollmer
force-pushed
the
storage-no-anaconda-mounting
branch
2 times, most recently
from
8a43c02
to
67a2b58
Compare
mvollmer
force-pushed
the
storage-no-anaconda-mounting
branch
2 times, most recently
from
03cea35
to
ce4995d
Compare
mvollmer
added
the
blocked
|
I'll resolve the pixel test merge conflict once #19800 is in. |
KKoukiou
previously approved these changes
Jan 12, 2024
mvollmer
added
no-test
mvollmer
force-pushed
the
storage-no-anaconda-mounting
branch
2 times, most recently
from
db28ed5
to
9274236
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
storage-no-anaconda-mounting
branch
from
9274236
to
6891849
Compare
This makes it easier to work with different sets of actions, and allows the primary action to have a tag as well.
It's the normal thing to do during installation.
mvollmer
force-pushed
the
storage-no-anaconda-mounting
branch
from
6891849
to
9acae42
Compare
jelly
approved these changes
Jan 15, 2024
cockpituous
reviewed
Jan 15, 2024
| } else if (backing_block != content_block) { | ||
| if (!opt_never_auto) | ||
| extra_text = _("The filesystem will be unlocked and mounted on the next boot. This might require inputting a passphrase."); | ||
| extra_text = _("The filesystem has no assigned mount point."); |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| mp_text = _("(not mounted)"); | ||
| } else { | ||
| if (client.in_anaconda_mode()) | ||
| mp_text = _("(no assigned mount point)"); |
There was a problem hiding this comment.
This added line is not executed by any test. Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://www.youtube.com/watch?v=Vtte11k6aQM