Pre-select autocomplete file when passing file path

[MahmoudHamdy02]

No description provided.

[KKoukiou]

Would be super nice to add some test

check testReactPatterns in test/verify/check-pages

[KKoukiou]

So although it generally works i think you overcomplicated this a bit. type can be autodetected from the component code. I suggest the following code (applied on top of your current branch) - its in my opinion a bit cleaner. Let me know what you think:

diff --git pkg/lib/cockpit-components-file-autocomplete.jsx pkg/lib/cockpit-components-file-autocomplete.jsx
index 378ff183e..8b9e8f546 100644
--- pkg/lib/cockpit-components-file-autocomplete.jsx
+++ pkg/lib/cockpit-components-file-autocomplete.jsx
@@ -32,13 +32,9 @@ export class FileAutoComplete extends React.Component {
             directory: '', // The current directory we list files/dirs from
             displayFiles: [],
             isOpen: false,
             value: this.props.value || null,
             type: this.props.type
         };
-        if (this.props.type === "file") {
-            this.props.onChange(this.props.value.slice(this.props.value.lastIndexOf("/") + 1));
-        }
-        this.updateFiles(props.value ? this.props.type === "file" ? props.value.slice(0, props.value.lastIndexOf("/") + 1) : props.value : "/");
         this.typeaheadInputValue = "";
         this.allowFilesUpdate = true;
         this.updateFiles = this.updateFiles.bind(this);
@@ -47,7 +43,7 @@ export class FileAutoComplete extends React.Component {
         this.clearSelection = this.clearSelection.bind(this);
         this.onCreateOption = this.onCreateOption.bind(this);
 
-        this.debouncedChange = debounce(300, (value) => {
+        this.onPathChange = (value) => {
             if (!value) {
                 this.clearSelection();
                 return;
@@ -84,7 +80,9 @@ export class FileAutoComplete extends React.Component {
                     return this.updateFiles(parentDir + '/');
                 }
             }
-        });
+        };
+        this.debouncedChange = debounce(300, this.onPathChange);
+        this.onPathChange(this.state.value);
     }
 

[MahmoudHamdy02]

@KKoukiou definitely cleaner! I've pushed the suggested code

[KKoukiou]

This is good now, but can you add a test for it as suggested here #19108 (review)

[KKoukiou]

And please squash all commits with next push.

[KKoukiou]

Hm tests now fail with mkdir: cannot create directory ‘/home/admin/newdir’: File exists

I was pretty sure that /home/admin directory get's cleanup but aparently no. Sorry for wrong hint. Please put self.restore_dir('/home/admin') in the start of the test.

[KKoukiou]

Needs squash on merge.