tools: Enable Python bridge on Fedora 38 #19009

martinpitt · 2023-06-25T06:23:54Z

After this, we can remove the fedora-38/pybridge scenario.

PR pybridge: Fix superuser startup vs. package reloading race #19025
PR pybridge: Fix ssh-agent launching #19029
PR pybridge: Fix cockpit_Machines directory lookup #19034
PR test: Switch check-client from "only" to a "skip" list #19038
more properly fix package loading (@allisonkarlitskaya is working on it) python bridge: rewrite packages.py #19065 ? Alternatively I added a commit to avoid the OOM failure

Move to Python bridge in Fedora 38 and CentOS Stream 9

The rewritten Python bridge that was introduced in Cockpit 294 gets enabled on Fedora 38 and CentOS Stream 9. Please let us know if you run into any trouble!

martinpitt · 2023-06-25T15:20:31Z

Oh, this is interesting -- it also enables the pybridge on Fedora CoreOS, which apparently needs some work.

martinpitt · 2023-06-26T09:55:23Z

Could you please do an initial review of this? I think I want to clean up the "memory eater" commit more, but I'd appreciate @allisonkarlitskaya 's gut feeling/judgement about that.

Also, @mvollmer, I suppose there was some particular reason for the init name of the superuser? Can you please have an initial look?

Thanks!

pyproject.toml

src/cockpit/packages.py

src/cockpit/superuser.py

martinpitt · 2023-06-26T09:53:31Z

src/cockpit/packages.py

@@ -317,11 +319,13 @@ def get_content_security_policy(self, origin):
    def serve_file(self, path, channel):
        if path == 'po.js':
            # We do locale-dependent lookup only for /po.js.  This always succeeds.
+            # Keep the file in memory for efficient lookups and manifests.js processing


I feel like this makes the types here unnecessarily complicated now. It would probably be fine to go all the way and drop the translations from memory as well.

src/cockpit/superuser.py

pyproject.toml

src/cockpit/packages.py

pyproject.toml

src/cockpit/packages.py

martinpitt · 2023-07-13T05:36:43Z

Fixed the conflict and dropped the memory saver patch for now. This will most probably fail the /devel scenario again, but let's make sure everything else still works.

martinpitt · 2023-07-13T06:24:49Z

The test actually looks a lot better now, as commit 1e191f9 already removed half of the RAM usage.

So my proposal is to work around that by giving the provisioned machine a bit more memory than 512 MiB in the devel scenario. This shouldn't be a big practical problem as real users are going to use the small production version of the pages. That would allow us to get some more field testing. @allisonkarlitskaya what is your gut feeling, should we still block this on your packages.py rework, or are you okay with unleashing it with the next release in two weeks?

allisonkarlitskaya · 2023-07-13T07:30:17Z

Give me another day on the packaging rework (and maybe start initially reviewing). It's not far now.

allisonkarlitskaya

🚀

allisonkarlitskaya · 2023-07-17T15:58:54Z

https://cockpit-logs.us-east-1.linodeobjects.com/pull-19009-20230717-150704-dacb340a-fedora-38-other/pixeldiff.html#TestHistoryMetrics-testEvents-metrics-history-expanded-hour-dark

Fascinating!!

The python bridge changes pixels in a way that we otherwise didn't notice from the integration tests yet. This definitely needs looking into.

broken pixel tests

martinpitt · 2023-07-17T16:28:02Z

We've been running pixel tests on /pybridge for a while now, to spot exactly such causes; but it happens with the C bridge as well. This is a known flake, retrying.

allisonkarlitskaya

This is a known flake, retrying.

aww too bad :)

+1, then.

cockpit-project/cockpit#19009 switched Fedora 38 to the pybridge for the "regular" build. Still keep the pybridge scenario for the other projects, until cockpit with the above PR got released and the fedora-38 image refreshed with it.

martinpitt marked this pull request as draft June 25, 2023 09:13

martinpitt force-pushed the pybridge-enable branch from dbb55d0 to 6a162c2 Compare June 25, 2023 09:16

martinpitt changed the title ~~tools: Enable Python bridge on Fedora 38 and CentOS/RHEL 9~~ tools: Enable Python bridge on Fedora 38 Jun 25, 2023

martinpitt force-pushed the pybridge-enable branch from 6a162c2 to 4674125 Compare June 25, 2023 09:19

martinpitt force-pushed the pybridge-enable branch from 4674125 to a02c31c Compare June 26, 2023 06:22

martinpitt mentioned this pull request Jun 26, 2023

"init" root pybridge gets stopped when finishing manifest reading #19014

Closed

martinpitt added the blocked Don't land until something else happens first (see task list) label Jun 26, 2023

martinpitt force-pushed the pybridge-enable branch from a02c31c to 6caa72c Compare June 26, 2023 09:47

martinpitt removed the blocked Don't land until something else happens first (see task list) label Jun 26, 2023

martinpitt requested review from allisonkarlitskaya and mvollmer June 26, 2023 09:53

martinpitt force-pushed the pybridge-enable branch from 6caa72c to 6cea6d5 Compare June 26, 2023 10:02

allisonkarlitskaya requested changes Jun 26, 2023

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

src/cockpit/packages.py Outdated Show resolved Hide resolved

src/cockpit/superuser.py Outdated Show resolved Hide resolved

martinpitt force-pushed the pybridge-enable branch 2 times, most recently from 1769f28 to e130840 Compare June 26, 2023 12:43

martinpitt commented Jun 26, 2023

View reviewed changes

martinpitt force-pushed the pybridge-enable branch from e130840 to 895a545 Compare June 26, 2023 17:26

martinpitt mentioned this pull request Jun 26, 2023

pybridge: Fix superuser startup vs. package reloading race #19025

Merged

martinpitt added blocked Don't land until something else happens first (see task list) no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Jun 26, 2023

martinpitt force-pushed the pybridge-enable branch from 895a545 to d24b895 Compare June 26, 2023 17:31

martinpitt mentioned this pull request Jun 26, 2023

tools: Enable Python bridge on RHEL/CentOS 9 #19011

Merged

4 tasks

martinpitt added the pybridge Python Bridge label Jun 27, 2023

This comment was marked as resolved.

Sign in to view

martinpitt mentioned this pull request Jun 27, 2023

pybridge: Fix ssh-agent launching #19029

Merged

martinpitt removed the blocked Don't land until something else happens first (see task list) label Jun 28, 2023

martinpitt force-pushed the pybridge-enable branch 2 times, most recently from 48401d9 to 57cc038 Compare June 28, 2023 08:19

martinpitt force-pushed the pybridge-enable branch from b26c142 to 4195a08 Compare June 28, 2023 10:33

martinpitt force-pushed the pybridge-enable branch from 4195a08 to 3a36307 Compare July 13, 2023 05:35

martinpitt added no-test For doc/workflow changes, or experiments which don't need a full CI run, and removed no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Jul 13, 2023

martinpitt removed the request for review from mvollmer July 13, 2023 05:48

martinpitt removed the blocked Don't land until something else happens first (see task list) label Jul 13, 2023

martinpitt marked this pull request as ready for review July 13, 2023 08:39

martinpitt requested a review from allisonkarlitskaya July 13, 2023 13:11

martinpitt added blocked Don't land until something else happens first (see task list) release-blocker Targetted for next release labels Jul 17, 2023

tools: Enable Python bridge on Fedora 38

dacb340

martinpitt added no-test For doc/workflow changes, or experiments which don't need a full CI run, and removed blocked Don't land until something else happens first (see task list) labels Jul 17, 2023

martinpitt force-pushed the pybridge-enable branch from dbeda3c to dacb340 Compare July 17, 2023 15:05

allisonkarlitskaya previously approved these changes Jul 17, 2023

View reviewed changes

martinpitt requested a review from allisonkarlitskaya July 17, 2023 16:28

allisonkarlitskaya approved these changes Jul 17, 2023

View reviewed changes

martinpitt merged commit 86510f8 into cockpit-project:main Jul 17, 2023
29 of 30 checks passed

martinpitt deleted the pybridge-enable branch July 17, 2023 16:58

martinpitt added the release-note label Jul 18, 2023

martinpitt mentioned this pull request Jul 18, 2023

testmap: Drop Fedora pybridge scenario for Cockpit cockpit-project/bots#5019

Merged

jelly removed the release-note label Aug 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: Enable Python bridge on Fedora 38 #19009

tools: Enable Python bridge on Fedora 38 #19009

martinpitt commented Jun 25, 2023 •

edited

Loading

martinpitt commented Jun 25, 2023

martinpitt commented Jun 26, 2023 •

edited

Loading

martinpitt Jun 26, 2023

This comment was marked as resolved.

martinpitt commented Jul 13, 2023

martinpitt commented Jul 13, 2023

allisonkarlitskaya commented Jul 13, 2023

allisonkarlitskaya left a comment

allisonkarlitskaya commented Jul 17, 2023

martinpitt commented Jul 17, 2023

allisonkarlitskaya left a comment

tools: Enable Python bridge on Fedora 38 #19009

tools: Enable Python bridge on Fedora 38 #19009

Conversation

martinpitt commented Jun 25, 2023 • edited Loading

Move to Python bridge in Fedora 38 and CentOS Stream 9

martinpitt commented Jun 25, 2023

martinpitt commented Jun 26, 2023 • edited Loading

martinpitt Jun 26, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

martinpitt commented Jul 13, 2023

martinpitt commented Jul 13, 2023

allisonkarlitskaya commented Jul 13, 2023

allisonkarlitskaya left a comment

Choose a reason for hiding this comment

allisonkarlitskaya commented Jul 17, 2023

martinpitt commented Jul 17, 2023

allisonkarlitskaya left a comment

Choose a reason for hiding this comment

martinpitt commented Jun 25, 2023 •

edited

Loading

martinpitt commented Jun 26, 2023 •

edited

Loading