Skip to content

Commit

Permalink
test: Drop global ignoring of two expected browser error messages
Browse files Browse the repository at this point in the history
Stop ignoring them globally, and move more specific replacements into
their corresponding tests. These two are justifiable and desired.
  • Loading branch information
martinpitt authored and jelly committed Oct 19, 2023
1 parent 6a5b725 commit 4937113
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/common/testlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1722,10 +1722,8 @@ def login_and_go(self, path: Optional[str] = None, user: Optional[str] = None, h
# messages from our own pages
"CPU temperature metric closed.*",
"failed to call cockpit.Machines.Update().*",
"Failed to enable pmproxy in firewalld.*",
"Getting properties for problem.*",
"Channel for reportd D-Bus client closed.*",
"checkRealm failed.*",
]

env_allow = os.environ.get("TEST_ALLOW_BROWSER_ERRORS")
Expand Down
1 change: 1 addition & 0 deletions test/verify/check-metrics
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@ class TestHistoryMetrics(testlib.MachineCase):
b.select_PF4("#firewalld-request-pmproxy", "comeandgo")
m.execute("firewall-cmd --permanent --delete-zone comeandgo; firewall-cmd --reload")
b.click(".pf-v5-c-alert button.pf-m-primary")
self.allow_browser_errors("Failed to enable pmproxy in firewalld:.*INVALID_ZONE: comeandgo.*")
b.wait_in_text(".pf-v5-c-alert.pf-m-warning", "Failed to enable pmproxy in firewalld")
b.wait_in_text(".pf-v5-c-alert.pf-m-warning", "INVALID_ZONE: comeandgo")
# close warning
Expand Down
1 change: 1 addition & 0 deletions test/verify/check-system-realms
Original file line number Diff line number Diff line change
Expand Up @@ -1148,6 +1148,7 @@ class TestPackageInstall(packagelib.PackageCase):

# case 1: disable PackageKit
m.execute("systemctl mask packagekit; systemctl stop packagekit.service || true")
self.allow_browser_errors('checkRealm failed.*"problem":"not-found"')
self.login_and_go("/system")
b.wait_text(self.domain_sel, "Join domain")
b.wait_visible(self.domain_sel + "[disabled]")
Expand Down

0 comments on commit 4937113

Please sign in to comment.