Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to d2e1f5d8f2345aa378803a8a939cb98f #1846

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 3, 2024

No description provided.

@github-actions github-actions bot added the bot label Oct 3, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to d2e1f5d8f2345aa378803a8a939cb98f Makefile: Update Cockpit lib to d2e1f5d8f2345aa378803a8a939cb98f Oct 3, 2024
@allisonkarlitskaya allisonkarlitskaya force-pushed the cockpit-lib-update-cockpit-lib-20241003-024333 branch from 208ba97 to 570755d Compare October 3, 2024 02:43
@jelly
Copy link
Member

jelly commented Oct 3, 2024

@jelly
Copy link
Member

jelly commented Oct 3, 2024

@jelly
Copy link
Member

jelly commented Oct 3, 2024

@martinpitt The issues here make sense, rhel-8-10 runs the C bridge not the Python bridge:

[root@rhel-8-10-127-0-0-2-2201 ~]# file /usr/bin/cockpit-bridge
/usr/bin/cockpit-bridge: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=f7ec016d699649e59de58639a079e69d53726d37, stripped

@martinpitt
Copy link
Member

Oh! That means that cockpit-project/cockpit#21055 regressed on the C bridge 😢 I thought fsinfo had a fallback for the C bridge, but I mixed that up with cockpit.file.watch()..

Feel free to revert cockpit-project/cockpit@03fcd56 then, as it still gets in the way. We can resurrect it once we drop support for these old distros.

@jelly
Copy link
Member

jelly commented Oct 7, 2024

Closing as this was the fsinfo changes where reverted in Cockpit

@jelly jelly closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants