-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Attach VM's XML and logs to a failed test #1158
Conversation
Fails everywhere:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a nice idea!
75fd5a0
to
41dfaba
Compare
Hmmm that's weird, locally I don't get the error Edit: Ah wait, I don't have ruff installed |
@skobyda ruff is installed in our cockpit/tasks container now, see https://github.com/cockpit-project/cockpit/blob/main/HACKING.md#setting-up-development-container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Do you have a failure somewhere to prove that it works?
This run has a flake, and the result dir at least has the XML (no log, though) |
Also no log here |
1abd4cd
to
53f6290
Compare
Fixed the VM logs (I forgot to run .strip() over output of m.execute). Now the result directory contains both the XML and VM logs: https://cockpit-logs.us-east-1.linodeobjects.com/pull-1158-20230803-071442-53f6290d-arch/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eeeeexcellent, thanks!
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
test/common/link-patterns.json