test: Attach VM's XML and logs to a failed test #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Fails everywhere: |
martinpitt
requested changes
Jul 30, 2023
skobyda
force-pushed
the
testVmArtifacts
branch
2 times, most recently
from
75fd5a0
to
41dfaba
Compare
|
Hmmm that's weird, locally I don't get the error Edit: Ah wait, I don't have ruff installed |
|
@skobyda ruff is installed in our cockpit/tasks container now, see https://github.com/cockpit-project/cockpit/blob/main/HACKING.md#setting-up-development-container |
martinpitt
approved these changes
Jul 31, 2023
|
This run has a flake, and the result dir at least has the XML (no log, though) |
|
Also no log here |
martinpitt
requested changes
Jul 31, 2023
skobyda
force-pushed
the
testVmArtifacts
branch
from
1abd4cd
to
53f6290
Compare
|
Fixed the VM logs (I forgot to run .strip() over output of m.execute). Now the result directory contains both the XML and VM logs: https://cockpit-logs.us-east-1.linodeobjects.com/pull-1158-20230803-071442-53f6290d-arch/index.html |
skobyda
added a commit
to skobyda/cockpit
that referenced
this pull request
Sep 6, 2023
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
skobyda
added a commit
to skobyda/cockpit
that referenced
this pull request
Sep 6, 2023
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
skobyda
added a commit
to skobyda/cockpit
that referenced
this pull request
Sep 6, 2023
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
skobyda
added a commit
to skobyda/cockpit
that referenced
this pull request
Sep 6, 2023
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
skobyda
added a commit
to skobyda/cockpit
that referenced
this pull request
Sep 6, 2023
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
martinpitt
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Sep 6, 2023
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/common/link-patterns.json