Skip to content

Commit

Permalink
Add spacing between the items inside the resource status label
Browse files Browse the repository at this point in the history
And test this through a pixel test.

Fixes #1111
  • Loading branch information
KKoukiou committed Oct 13, 2023
1 parent 941b8cd commit f07751f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/components/common/stateIcon.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
// Add some space between resource status and possible error state
.resource-state-text .pf-v5-c-label__text {
display: flex;
gap: var(--pf-v5-global--spacer--xs);
}

.resource-state-text:first-child {
// In definition lists (for Overview),
// match text size and alignment
Expand Down
2 changes: 2 additions & 0 deletions test/check-machines-lifecycle
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ class TestMachinesLifecycle(VirtualMachinesCase):

# Try to run subVmTest1 - it will fail because of inactive default network
tryRunDomain(1, 'subVmTest1', 'system')
b.wait_visible("#vm-subVmTest1-system-state-error")
b.assert_pixels("#virtual-machines-page", "main-page-vm-error")
b.click('#vm-subVmTest1-system-state-error button:contains("view more")')
b.wait_in_text(".pf-v5-c-popover", "VM subVmTest1 failed to start")
b.click('#vm-subVmTest1-system-state-error button[aria-label=Close]')
Expand Down

0 comments on commit f07751f

Please sign in to comment.