Skip to content

Commit

Permalink
appstream: Fix validation problems
Browse files Browse the repository at this point in the history
Rename the file to match its ID, fix the ID (extra cockpit- prefix), and
add developer tag. This fixes all issues with `appstreamcli validate`:

> I: org.cockpit_project.cockpit_machines: developer-info-missing
> W: org.cockpit_project.cockpit_machines: metainfo-filename-cid-mismatch
  • Loading branch information
martinpitt committed Oct 11, 2024
1 parent cda355e commit 8254c79
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ TARFILE=$(RPM_NAME)-$(VERSION).tar.xz
NODE_CACHE=$(RPM_NAME)-node-$(VERSION).tar.xz
SPEC=$(RPM_NAME).spec
PREFIX ?= /usr/local
APPSTREAMFILE=org.cockpit-project.$(PACKAGE_NAME).metainfo.xml
APPSTREAMFILE=org.cockpit_project.$(PACKAGE_NAME).metainfo.xml
VM_IMAGE=$(CURDIR)/test/images/$(TEST_OS)
# stamp file to check for node_modules/
NODE_MODULES_TEST=package-lock.json
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<component type="addon">
<id>org.cockpit_project.cockpit_machines</id>
<id>org.cockpit_project.machines</id>
<metadata_license>CC0-1.0</metadata_license>
<name>Machines</name>
<summary>Manage your virtual machines</summary>
Expand All @@ -15,4 +15,7 @@
<launchable type="cockpit-manifest">machines</launchable>
<url type="homepage">https://cockpit-project.org/</url>
<update_contact>cockpit-devel_AT_lists.fedorahosted.org</update_contact>
<developer id="org.cockpit-project">
<name>Cockpit Project</name>
</developer>
</component>

0 comments on commit 8254c79

Please sign in to comment.