Skip to content

Commit

Permalink
Replace deprecated font redhat--monospace with basic PF's monospace
Browse files Browse the repository at this point in the history
PF dropped pf-v5-global--FontFamily--redhat--monospace since
patternfly/patternfly@4ec21e34fc3
  • Loading branch information
skobyda committed Aug 15, 2023
1 parent f0adee2 commit 7fee9d7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/machines.scss
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
}

.ct-monospace {
font-family: var(--pf-v5-global--FontFamily--redhat--monospace);
font-family: var(--pf-v5-global--FontFamily--monospace);
}

// Do not add a box-shadow to a "subsection", while it's technically correct it looks weird.
Expand Down
6 changes: 6 additions & 0 deletions test/check-machines-disks
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ class TestMachinesDisks(VirtualMachinesCase):
pool_name=None, volume_name=None,
file_path=None,
force=False,
pixel_tag=None,
):
self.test_obj = test_obj
self.mode = mode
Expand All @@ -311,6 +312,7 @@ class TestMachinesDisks(VirtualMachinesCase):
self.volume_name = volume_name
self.target = target
self.force = force
self.pixel_tag = pixel_tag

def _get_disks(self):
m = self.test_obj.machine
Expand Down Expand Up @@ -403,6 +405,9 @@ class TestMachinesDisks(VirtualMachinesCase):
b.click(f"#vm-{self.vm_name}-disks-{self.target}-eject-button") # button
b.wait_in_text(".pf-v5-c-modal-box__title", "Eject disc from VM")

if self.pixel_tag:
b.assert_pixels(".pf-v5-c-modal-box", self.pixel_tag)

if self.mode == "custom-path":
b.wait_in_text(f"#vm-{self.vm_name}-disks-{self.target}-modal-description-file", self.file_path)
elif self.mode == "use-existing":
Expand Down Expand Up @@ -1632,6 +1637,7 @@ class TestMachinesDisks(VirtualMachinesCase):
mode='custom-path',
target='sda',
file_path='/var/lib/libvirt/novell.iso',
pixel_tag='vm-disc-eject-modal',
).execute()

self.VMInsertMediaDialog(
Expand Down

0 comments on commit 7fee9d7

Please sign in to comment.