Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image refresh for rhel-9-6 #7004

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

cockpituous
Copy link
Contributor

@cockpituous cockpituous commented Oct 17, 2024

Image refresh for rhel-9-6

  • image-refresh rhel-9-6

@github-actions github-actions bot added the bot label Oct 17, 2024
@cockpituous cockpituous changed the title Image refresh for rhel-9-6 WIP: f2afda3d64d4: [no-test] Image refresh for rhel-9-6 Oct 17, 2024
@cockpituous
Copy link
Contributor

cockpituous pushed a commit that referenced this pull request Oct 17, 2024
@cockpituous cockpituous force-pushed the image-refresh-rhel-9-6-20241017-225558 branch from 7e5c020 to 991ff7d Compare October 17, 2024 22:56
@cockpituous cockpituous changed the title WIP: f2afda3d64d4: [no-test] Image refresh for rhel-9-6 Image refresh for rhel-9-6 Oct 17, 2024
@cockpituous
Copy link
Contributor

@martinpitt
Copy link
Member

This kdump nfs failure may be real -- there's no new kdump, but a new kernel. Retrying once to compare, then investigating.

@martinpitt
Copy link
Member

martinpitt commented Oct 18, 2024

There's indeed a regression. On the main image, kdump.service fails properly with an invalid config:

× kdump.service - Crash recovery kernel arming
     Loaded: loaded (/usr/lib/systemd/system/kdump.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Fri 2024-10-18 02:26:05 EDT; 3min 14s ago
   Duration: 5.194s
    Process: 1911 ExecStart=/usr/bin/kdumpctl start (code=exited, status=1/FAILURE)
   Main PID: 1911 (code=exited, status=1/FAILURE)
        CPU: 464ms

Oct 18 02:26:03 rhel-9-6-127-0-0-2-2201 systemd[1]: Starting Crash recovery kernel arming...
Oct 18 02:26:04 rhel-9-6-127-0-0-2-2201 kdumpctl[1934]: kdump: Detected change(s) in the following file(s):  /etc/kdump.conf
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 kdumpctl[1934]: kdump: Rebuilding /boot/initramfs-5.14.0-516.el9.x86_64kdump.img
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 kdumpctl[2426]: kdump: Dump path "dumps" does not exist in dump target "10.111.113.2:/srv/kdump"
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 kdumpctl[1934]: kdump: mkdumprd: failed to make kdump initrd
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 kdumpctl[1934]: kdump: Starting kdump: [FAILED]
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 systemd[1]: kdump.service: Main process exited, code=exited, status=1/FAILURE
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 systemd[1]: kdump.service: Failed with result 'exit-code'.
Oct 18 02:26:05 rhel-9-6-127-0-0-2-2201 systemd[1]: Failed to start Crash recovery kernel arming.

but on the new image it succeeds despite seeing the error:

● kdump.service - Crash recovery kernel arming
     Loaded: loaded (/usr/lib/systemd/system/kdump.service; enabled; preset: enabled)
     Active: active (exited) since Fri 2024-10-18 02:28:51 EDT; 30s ago
    Process: 1763 ExecStart=/usr/bin/kdumpctl start (code=exited, status=0/SUCCESS)
   Main PID: 1763 (code=exited, status=0/SUCCESS)
        CPU: 900ms

Oct 18 02:28:48 rhel-9-6-127-0-0-2-2201 systemd[1]: Starting Crash recovery kernel arming...
Oct 18 02:28:49 rhel-9-6-127-0-0-2-2201 kdumpctl[1786]: kdump: Detected change(s) in the following file(s):  /etc/kdump.conf
Oct 18 02:28:50 rhel-9-6-127-0-0-2-2201 kdumpctl[1786]: kdump: Rebuilding /boot/initramfs-5.14.0-518.el9.x86_64kdump.img
Oct 18 02:28:51 rhel-9-6-127-0-0-2-2201 kdumpctl[2276]: kdump: Dump path "dumps" does not exist in dump target "10.111.113.2:/srv/kdump"
Oct 18 02:28:51 rhel-9-6-127-0-0-2-2201 kdumpctl[1786]: kdump: mkdumprd: failed to make kdump initrd
Oct 18 02:28:51 rhel-9-6-127-0-0-2-2201 kdumpctl[1786]: kdump: kexec: loaded kdump kernel
Oct 18 02:28:51 rhel-9-6-127-0-0-2-2201 kdumpctl[1786]: kdump: Starting kdump: [OK]
Oct 18 02:28:51 rhel-9-6-127-0-0-2-2201 kdumpctl[1786]: kdump: Notice: No vmcore creation test performed!
Oct 18 02:28:51 rhel-9-6-127-0-0-2-2201 systemd[1]: Finished Crash recovery kernel arming.

Same result with kdumpctl start, it exits with 0 on the new image now.

This doesn't actually need a running NFS server, can just be tested with nfs unknown.local:/srv/kdump. Reproducer on clean image:

echo 'nfs unknown.local:/srv/kdump' >> /etc/kdump.conf 
kdumpctl stop
kdumpctl start; echo $?

With old kernel-core-5.14.0-516.el9.x86_64 and kexec-tools-2.0.27-16.el9_5.1.x86_64 it correctly fails:

kdump: Detected change(s) in the following file(s):  /etc/kdump.conf
kdump: Rebuilding /boot/initramfs-5.14.0-516.el9.x86_64kdump.img
mount.nfs: Failed to resolve server unknown.local: Name or service not known
kdump: Failed to mount unknown.local:/srv/kdump for kdump preflight check. Please make sure nfs-utils has been installed.
kdump: mkdumprd: failed to make kdump initrd
kdump: Starting kdump: [FAILED]
1

with kexec-tools-2.0.27-17.el9.x86_64 it wrongly succeeds:

kdump: Detected change(s) in the following file(s):  /etc/kdump.conf
kdump: Rebuilding /boot/initramfs-5.14.0-518.el9.x86_64kdump.img
mount.nfs: Failed to resolve server unknown.local: Name or service not known
kdump: Failed to mount unknown.local:/srv/kdump for kdump preflight check. Please make sure nfs-utils has been installed.
kdump: mkdumprd: failed to make kdump initrd
kdump: kexec: loaded kdump kernel
kdump: Starting kdump: [OK]
kdump: Notice: No vmcore creation test performed!
0

It's enough to just update that one package.

This was changed in https://gitlab.com/redhat/centos-stream/rpms/kexec-tools/-/merge_requests/245 and it only refers to https://issues.redhat.com/browse/RHEL-32060 which is unrelated. So this doesn't look like an intentional behaviour change, but a bad backport.

Reported to https://issues.redhat.com/browse/RHEL-63047

@martinpitt martinpitt force-pushed the image-refresh-rhel-9-6-20241017-225558 branch from 991ff7d to 5e5c314 Compare October 18, 2024 06:58
@martinpitt martinpitt self-assigned this Oct 18, 2024
@martinpitt martinpitt requested a review from jelly October 18, 2024 07:26
@jelly jelly merged commit 14af78e into main Oct 18, 2024
16 checks passed
jelly pushed a commit that referenced this pull request Oct 18, 2024
@jelly jelly deleted the image-refresh-rhel-9-6-20241017-225558 branch October 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants