use external kickstart file for rhel4edge image

[jscotka]

Image refresh for rhel4edge ( replaces: #5810)

• image-refresh rhel4edge

Fixes #5774

[cockpituous]

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240123-101035

[cockpituous]

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/rhel4edge-20240123-101010.log

[martinpitt]

Thanks so much for figuring this out! This is a lot better! 🎉

It just bothers me a bit to keep a duplicate of that sizable .ks file in our tree -- it will quickly grow out of date. It's also not documented how it was extracted and what was modified. Supposedly it's 99% the same with just some modifications?

Would it be possible to instead do that dynamically? Extract the .ks with isoinfo, and then depending on how complex the changes are, use sed -i or patch to apply the modifications? Then it will keep itself up to date, and we'll immediately know when there's a conflict.

Thanks!

[cockpituous]

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/rhel4edge-20240123-150707.log

[martinpitt]

That failure looked rather random, let's try again.

[cockpituous]

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/rhel4edge-20240123-155656.log

[martinpitt]

OK, this failed twice in a row now, apparently there's something wrong?

�[K�[1;24r�[23;1HInstalling boot loader�[1;23r�[23;1H
�[K�[1;24r�[23;1H.
ERROR    Cannot write data: Broken pipe
Domain installation does not appear to have been successful.
If it was, you can restart your domain by running:
  virsh --connect qemu:///session start rhel4edgeodehods9.qcow2-builder
otherwise, please restart your installation.
+ rm rhel4edge-1706023131.iso.ks
rm: cannot remove 'rhel4edge-1706023131.iso.ks': No such file or directory

[jscotka]

Hi, this error seems very odd. I'll look at it. Thinking about if it this cannot be caused by some external event, like that disk space in podman container were exhausted or some problem with terminal. I'm curious.

[jscotka]

Try to reschedule build again

[cockpituous]

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/rhel4edge-20240124-120808.log

[cockpituous]

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240124-162319

[cockpituous]

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/rhel4edge-20240124-162323.log

[martinpitt]

Isn't this what virt-install's --wait option is for? So --wait 10 should wait for 10 mins, like you do here, but without shell polling.

[jscotka]

Isn't this what virt-install's --wait option is for? So --wait 10 should wait for 10 mins, like you do here, but without shell polling.

I think it could be used, but problem will be caused, when the error occurs, it will hang for 10 minutes. Instead of fail early. because fail is faster than installation.

[cockpituous]

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240126-150501

[cockpituous]

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/rhel4edge-20240126-150505.log

[martinpitt]

Thanks @jscotka for figuring this out! 🌟 I see a few small and unimportant niggles, but they really shouldn't block this.

I'm still rather disappointed how hard it is to get and install an Edge image..