-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use external kickstart file for rhel4edge image #5825
Conversation
image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240123-101035 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for figuring this out! This is a lot better! 🎉
It just bothers me a bit to keep a duplicate of that sizable .ks file in our tree -- it will quickly grow out of date. It's also not documented how it was extracted and what was modified. Supposedly it's 99% the same with just some modifications?
Would it be possible to instead do that dynamically? Extract the .ks with isoinfo
, and then depending on how complex the changes are, use sed -i
or patch
to apply the modifications? Then it will keep itself up to date, and we'll immediately know when there's a conflict.
Thanks!
That failure looked rather random, let's try again. |
OK, this failed twice in a row now, apparently there's something wrong?
|
Hi, this error seems very odd. I'll look at it. Thinking about if it this cannot be caused by some external event, like that disk space in podman container were exhausted or some problem with terminal. I'm curious. |
Try to reschedule build again |
image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240124-162319 |
# Wait until installation ends (with maximum timeout 30*20 sec) | ||
# check console output for errors if it appears to end early | ||
# if machine succeed it goes to "shut off" state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this what virt-install's --wait
option is for? So --wait 10
should wait for 10 mins, like you do here, but without shell polling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this what virt-install's
--wait
option is for? So--wait 10
should wait for 10 mins, like you do here, but without shell polling.
I think it could be used, but problem will be caused, when the error occurs, it will hang for 10 minutes. Instead of fail early. because fail is faster than installation.
image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240126-150501 |
add newly created issue related to this workaround try to use method noninteractive method without expect PR review, do not actively wait, let the timeout to virt-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jscotka for figuring this out! 🌟 I see a few small and unimportant niggles, but they really shouldn't block this.
I'm still rather disappointed how hard it is to get and install an Edge image..
Image refresh for rhel4edge ( replaces: #5810)
Fixes #5774