do not compare types, use isinstance

cockpit-project · Aug 21, 2023 · d0f8dcd · d0f8dcd
1 parent fddb66c
commit d0f8dcd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/run-queue b/run-queue
@@ -166,12 +166,12 @@ def main():
             logging.info("All queues are empty")
             return 1
 
-        if type(cmd) is list:
+        if isinstance(cmd, list):
             cmd_str = ' '.join(cmd)
         else:
             cmd_str = cmd
         logging.info("Consuming message with command: %s", cmd_str)
-        p = subprocess.Popen(cmd, shell=type(cmd) is str)
+        p = subprocess.Popen(cmd, shell=isinstance(cmd, str))
         while p.poll() is None:
             q.connection.process_data_events()
             time.sleep(3)