Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(landing): try to pimp the landing page #57

Open
wants to merge 1 commit into
base: source
Choose a base branch
from

Conversation

Geobert
Copy link
Contributor

@Geobert Geobert commented Jan 17, 2019

No description provided.

@Geobert
Copy link
Contributor Author

Geobert commented Jan 25, 2019

@epage : I feel there's an issue with this, isn't it? ^^'

@epage
Copy link
Member

epage commented Jan 26, 2019

feel there's an issue with this, isn't it? ^^'

Well, I had some feedback but I also have been getting really far behind as well which is the bigger issue.

Copy link
Member

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working to improve the site!

@@ -10,18 +10,24 @@ layout: landing.liquid
<article>
<h3>Simple</h3>
<p>Cobalt will help you get up and running quickly but scales to handle
your more complex cases</p>
your more complex cases: multiple <b>collections</b>, <b>tagging</b>, <b>categories</b>…</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple collections doesn't exist yet. I also feel like tagging and categories are too weak right now (without your index work) to really talk them up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm gonna find something else and we'll add tags and categories once indexation for them are done :)

</article>
<article>
<h3>Fast</h3>
<p>Written in Rust, Cobalt is blazing fast and allows you to quickly see
<p>Written in <b>Rust</b>, Cobalt is blazing fast even with
<b>sass</b> and <b>syntax highlighting</b>, and allows you to quickly see
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, can we really say it is fast? How is our sass and syntax highlighting compared to others? For example, I think both are relying on C libraries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is quite arbitrary but it's what a landing page do :-/ I know you want to be honest, but I can't say that cobalt feels slow neither, it behaves pretty fast to me (until the indexation on tags which is slow in debug, as I said in cobalt-org/cobalt.rs#548). So we're not really lying. That's what marketing is about :-/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justifications don't need to be on the landing page but we should be able to back them up. Whenever I see a program get posted to Hacker News, or Proggit, it gets shredded by people if the numbers can't be backed up which can then hurt perception.

btw regarding justifications, I've been considering ideas for sharing more information on the claims

  • Sections below the fold
  • Provide details below when hover or select each claim
  • link to pages with more detail

Whichever one we choose, it doesn't have to be in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever I see a program get posted to Hacker News, or Proggit, it gets shredded by people if the numbers can't be backed up which can then hurt perception.

Oh, I didn't know that as I don't go there myself. I'll change that.

I think link to pages with more detail is clearer. Section below the fold will make the page too clutter, and on hover seems not really intuitive as there nothing to click, it's not natural to put the mouse hover.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think link to pages with more detail is clearer. Section below the fold will make the page too clutter, and on hover seems not really intuitive as there nothing to click, it's not natural to put the mouse hover.

And yet ive seen each of them on company websites :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, Im not defending just finding it amusing the trends in site layout and their problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yet ive seen each of them on company websites :)
Since when a company website is a good practice ;-p

index.liquid Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants