Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coala command: use --limit-files #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

coala command: use --limit-files #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .coafile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
[Default]
enabled = True

[commit]
bears = GitCommitBear

[python]
bears = PEP8Bear
files = **.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per gitmate result #18 (comment) maybe put the test files into an ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 875adbc which ignores the test file from root and includes it in the test subfolder (so that cask exec ert-runner picks it up). Test works, a local coala run from the root ignores the test file, but gitmate is still complaining. What am I missing? Is there a separate gitmate config?

ignore = test/resources/language/*.py
2 changes: 1 addition & 1 deletion flycheck-coala.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
(flycheck-define-checker coala
"A checker using coala.
See URL `https://coala.io'."
:command ("coala" "--format" "{line}:{column}:{severity_str}:{message}" "--find-config" "--files" source)
:command ("coala" "--format" "{line}:{column}:{severity_str}:{message}" "--find-config" "--limit-files" source-original)
:error-patterns ((error (or "None" line) ":" (or "None" column) ":MAJOR:" (message))
(warning (or "None" line) ":" (or "None" column) ":NORMAL:" (message))
(info (or "None" line) ":" (or "None" column) ":INFO:" (message)))
Expand Down
3 changes: 3 additions & 0 deletions test/resources/language/.coafile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[python]
bears = PEP8Bear
files = *.py