Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLintBearLogo.svg #69

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Add ESLintBearLogo.svg #69

merged 1 commit into from
Nov 22, 2018

Conversation

kiy4h
Copy link
Contributor

@kiy4h kiy4h commented Nov 20, 2018

Added ESLintBearLogo.svg in /artwork/logo/bears/

Related to #21

Added ESLintBearLogo.svg in /artwork/logo/bears/

Related to coala#21
Copy link

@srivama srivama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the ESL logo on the SE corner, that might look better ;)

@kiy4h
Copy link
Contributor Author

kiy4h commented Nov 21, 2018

@srivama I tried putting the ESLint logo in all corners and here's the result:

img

I think I like the bottom left one the best, what do you think?

@kiy4h
Copy link
Contributor Author

kiy4h commented Nov 21, 2018

Or, if you think the ESL logo is too big, I resized it to 1/4 of coala logo's width:

whichlogoisbestsmaller

But I think they're too small for some reason, or maybe that's just my design taste ;)

@srivama
Copy link

srivama commented Nov 21, 2018

You're right. Bottom left 1/3rd looks good :)

@sangamcse
Copy link
Member

ack 5910706

@sangamcse
Copy link
Member

@gitmate-bot ff

@jayvdb
Copy link
Member

jayvdb commented Nov 22, 2018

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@jayvdb jayvdb merged commit 5910706 into coala:master Nov 22, 2018
@jayvdb
Copy link
Member

jayvdb commented Nov 22, 2018

Automated fastforward with GitMate.io was successful! 🎉

@kiy4h kiy4h deleted the issue-21 branch December 9, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants