ameba: Remove ameba from shard dependencies #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameba is a linting tool, which isn't being used in our CI pipelines, and causes complications with crystal version update. Ameba dependency should be removed from cnf-testcatalog shards and usage guidelines should point to more independent usage via installing the linter from source. Refs: cnti-testcatalog#2157 Signed-off-by: Konstantin Yarovoy <[email protected]>
martin-mat
requested review from
taylor,
collivier,
martin-mat,
Smitholi67,
barmull and
svteb
martin-mat
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
lgtm as addressing immediate issues with ameba.
Target solution to be addressed as a part of #2159
Smitholi67
approved these changes
Sep 30, 2024
Signed-off-by: Martin Matyas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ameba is a linting tool, which isn't being used in our CI pipelines, and causes complications with crystal version update.
Ameba dependency should be removed from cnf-testcatalog shards and usage guidelines should point to more independent usage via installing the linter from source.
Issues:
Refs: #2157