Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1807] Add task runtime info to results file if TASK_TIMESTAMPS env var is set #1808

Merged
merged 8 commits into from
Aug 2, 2023
Merged

[1807] Add task runtime info to results file if TASK_TIMESTAMPS env var is set #1808

merged 8 commits into from
Aug 2, 2023

Conversation

HashNuke
Copy link
Collaborator

@HashNuke HashNuke commented Jul 28, 2023 •
edited
Loading

Issues

Refs: #1807

Description

When TASK_TIMESTAMPS env var is set when running any tests, the following fields are added to every test in the results file:

  • start_time - Timestamp in UTC when the task was started
  • end_time - Timestamp in UTC when the task was completed (ended)
  • task_runtime_milliseconds - Time required for this task to run in milliseconds.

Screenshot of results file when TASK_TIMESTAMPS env is set

TASK_TIMESTAMPS=true ./cnf-testsuite cert
CleanShot 2023-07-28 at 11 11 56@2x

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@HashNuke
Update all task result helpers to include start_time
d93bd28 
Signed-off-by: Akash Manohar <[email protected]>

Add start_time arg to upsert_* function calls

Signed-off-by: Akash Manohar <[email protected]>

Fix typo in points.cr

Signed-off-by: Akash Manohar <[email protected]>

Fix typo in cluster_admin test

Signed-off-by: Akash Manohar <[email protected]>

Update reliability, security and state workload tests

Signed-off-by: Akash Manohar <[email protected]>
@HashNuke
Add task result info as a hash
b41ed80 
Signed-off-by: Akash Manohar <[email protected]>
@HashNuke
Encode into yaml and parse it again
383e8c4 
Signed-off-by: Akash Manohar <[email protected]>
@HashNuke
Use milliseconds instead of seconds
a4f21a1 
Signed-off-by: Akash Manohar <[email protected]>
@HashNuke
Enable timestamps only if TASK_TIMESTAMPS is set
c8a0e74 
Signed-off-by: Akash Manohar <[email protected]>
@HashNuke
Resolve type issues for task result hash
1c2bbe7 
Signed-off-by: Akash Manohar <[email protected]>
agentpoyo
agentpoyo approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to test prior to merging.

@agentpoyo agentpoyo merged commit 2fa102b into main Aug 2, 2023
181 of 183 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentpoyo agentpoyo agentpoyo approved these changes

@denverwilliams denverwilliams Awaiting requested review from denverwilliams denverwilliams is a code owner

@wvwatson wvwatson Awaiting requested review from wvwatson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashNuke @agentpoyo