Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dockerfile for pyne vs Python/moab5.0/dagmc #4

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Jan 30, 2019

No description provided.

@gonuke
Copy link
Member

gonuke commented Jan 30, 2019

Perhaps we should add entries to the README to catalog what we have?

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, it maybe it depends on the last comment about dev vs stable

&& cd moab \
&& git clone https://bitbucket.org/fathomteam/moab \
&& cd moab \
&& git checkout -b Version5.0 origin/Version5.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we used version 5.1.0

Copy link
Member Author

@bam241 bam241 Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes my bad, I tried Version5.1, but it does not exist as they named it Version5.1.0...
updating that...

&& cd .. \
&& mkdir build \
&& cd build \
&& ../moab/configure --enable-shared --enable-dagmc --enable-pymoab \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we build with CMake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

&& git checkout kkiesling-python3 \
&& python3 setup.py install --user \
--moab $HOME/opt/moab --dagmc $HOME/opt/dagmc --clean
ENV PYTHONPATH=$HOME/opt/moab/lib/python3.6/site-packages/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn’t this path change as python 3.x changes?

# Install PyNE
RUN pip3 install cython --force-reinstall
RUN cd $HOME/opt \
&& git clone https://github.com/bam241/pyne.git \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to commit these with such non-standard repos and branches.

Maybe we can have a development folder and a production folder. The former is for sharing things that are specialized and non-standard (hopefully only in transition) and the latter for more stable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course, sorry about that that was a copy paste of the dockerfile I was using to test pyne stuff... I forgot to change it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gonuke do we want to rely on cnerg forks (when we have them) or main repos ?

@bam241
Copy link
Member Author

bam241 commented Jan 30, 2019

this won't work yet on pyne/develop branch as long as the pymoab_cleanup is not ready, maybe we should wait to merge this for the develop branch to be updated

@bam241
Copy link
Member Author

bam241 commented Jan 30, 2019

@gonuke what do you think about an architecture like this ?

@bam241 bam241 changed the title Adding dockerfile for pyne vs Python3.6/moab5.0/dagmc Adding dockerfile for pyne vs Python/moab5.0/dagmc Jan 30, 2019
@bam241
Copy link
Member Author

bam241 commented Jan 30, 2019

I am thinking that we could tag all of them with the same name, to avoid keeping all the temporary ones in memory, it could also allow users to build a big container with multiple of our softwares/dependencies

@gonuke gonuke changed the base branch from master to main June 23, 2020 12:07
kkiesling added a commit to kkiesling/dockerfiles that referenced this pull request Aug 1, 2020
Add blank line at end to see if DH triggers on py3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants