Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update Makefile to docker compose v2 #1347

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

brandtkeller
Copy link
Contributor

@brandtkeller brandtkeller commented Aug 15, 2024

Description

Noticed failures with CI processes in Pull Requests. Noticed that our use of ubuntu-latest may have resulted in these issues after the removal of docker compose v1.

Updates

  • Update Makefile to use docker compose v2 syntax
  • Remove obsolete version in docker-compose.yml
  • Update the TAG-Security-Linter to use the latest version of actions/checkout pinned to the commit SHA to remove deprecation warnings with the use of older node actions.

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for tag-security ready!

Name Link
🔨 Latest commit 0e7e25b
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/66be716a23dfee000886c146
😎 Deploy Preview https://deploy-preview-1347--tag-security.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandtkeller brandtkeller marked this pull request as ready for review August 15, 2024 21:26
Copy link
Collaborator

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Bugfix, so merging now

@eddie-knight eddie-knight merged commit ba3732f into cncf:main Aug 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants