Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Knative repos #1070

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented May 9, 2023

Add more Knative repos, per knative/test-infra#3632 (comment)

@aliok aliok force-pushed the 2023-05-09-add-more-knative-repos branch from 4a49c49 to 16a4a83 Compare May 9, 2023 10:28
Copy link
Contributor

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aliok!

@aliok
Copy link
Member Author

aliok commented May 9, 2023

@tegioz

How can I add the subprojects in Knative that live outside of github.com/knative GitHub organization?

Some examples:

Would this work:

    - name: sandbox/eventing-kafka-broker
      url: https://github.com/knative-sandbox/eventing-kafka-broker
      check_sets:
        - code-lite

Also, is there a way to exclude these from the health reports but have them in CLOTributor?

@tegioz
Copy link
Contributor

tegioz commented May 9, 2023

Would this work:

    - name: sandbox/eventing-kafka-broker
      url: https://github.com/knative-sandbox/eventing-kafka-broker
      check_sets:
        - code-lite

Yes, you can add more repositories that way 👍

Also, is there a way to exclude these from the health reports but have them in CLOTributor?

No, not at the moment. But this is an interesting request, we'll make this possible 🙂

@aliok
Copy link
Member Author

aliok commented May 9, 2023

Yes, you can add more repositories that way 👍

Thanks, I will create a separate PR for that.

No, not at the moment. But this is an interesting request, we'll make this possible 🙂

I can be the tester for that feature, if you would need a hand :)

My motivation for that feature request is:

@tegioz
Copy link
Contributor

tegioz commented May 9, 2023

I can be the tester for that feature, if you would need a hand :)

Sure, that'd be great, thanks 🙂

My motivation for that feature request is:

Yes, that makes sense 👍

@tegioz tegioz merged commit 965a713 into cncf:main May 9, 2023
@aliok aliok deleted the 2023-05-09-add-more-knative-repos branch May 9, 2023 10:44
@tegioz
Copy link
Contributor

tegioz commented May 10, 2023

#1074 has been deployed @aliok 🙂

@aliok
Copy link
Member Author

aliok commented May 10, 2023

@tegioz you're so fast! Thanks for adding this feature so quickly.

Let me send a PR for the other Knative repos with exclude: \n - clomonitor

@tegioz
Copy link
Contributor

tegioz commented May 10, 2023

Cool, no worries!

Comment on lines +1013 to +1016
- name: test-infra
url: https://github.com/knative/test-infra
check_sets:
- code-lite
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be knative/infra now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #1264 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants