Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more integer types #57

Merged
merged 4 commits into from
Feb 11, 2024
Merged

feat: support more integer types #57

merged 4 commits into from
Feb 11, 2024

Conversation

Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented Feb 11, 2024

  • Support more DataFusion integer types.
  • Instead of converting every integer type to Int64, define more variants of integers.
  • Add SQL planner test for integer constant predicate.

This fix only works when DF's optimizer rules are not cleared. DF treats integer constants as Int64, therefore to compare columns with other integer types with the constant it needs to be cast to Int64, which is currently not supported by optd.

To implement Cast expression, we will need to support multiple values in RelNode's value field.

Copy link
Contributor

@AveryQi115 AveryQi115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The schema pr will also based on these added types

@AveryQi115 AveryQi115 mentioned this pull request Feb 11, 2024
4 tasks
@jurplel
Copy link
Member

jurplel commented Feb 11, 2024

lgtm!

Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you tested these without logical optimizer enabled? Did those break anything?

@Gun9niR Gun9niR merged commit 79c4664 into main Feb 11, 2024
1 check passed
@Gun9niR Gun9niR deleted the zhidong/fix_int branch February 11, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants