Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle null_frac in LIKE #179

Merged
merged 1 commit into from
May 1, 2024
Merged

fix: correctly handle null_frac in LIKE #179

merged 1 commit into from
May 1, 2024

Conversation

Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented May 1, 2024

Since MCV already considers null_frac, we can remove * (1 - null_frac).

Copy link
Member

@wangpatrick57 wangpatrick57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gun9niR Gun9niR merged commit 182b052 into main May 1, 2024
1 check passed
@Gun9niR Gun9niR deleted the zhidong/fix-like branch May 1, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants