Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] adjust the L1T seeds to be monitored from L1TStage2uGTTiming in Run3 PbPb modes #46600

Open
wants to merge 1 commit into
base: CMSSW_14_1_X
Choose a base branch
from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 4, 2024

backport of #46590

PR description:

Addresses #43488 (comment), by removing from DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py the monitoring seeds not existing in the Run3 PbPb L1T menus.

PR validation:

Run the setup at #46584 (comment) with this commit and verified that the noisy warnings are removed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #46590 to the production cycle of the 2024 PbPb run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Nov 4, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-596feb/42583/summary.html
COMMIT: f01e1bf
CMSSW: CMSSW_14_1_X_2024-11-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46600/42583/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 48 lines to the logs
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565638
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants