Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the egamma regression for 2023 UPC PbPb rereco #46562

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update the egamma regression for 2023 UPC PbPb rereco #46562

wants to merge 1 commit into from

Conversation

stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Oct 31, 2024 •
edited
Loading

PR description:

This PR updates the egamma regression for 2023 UPC PbPb rereco through the use of the Run3_2023_UPC era.
Pending to update the global tag with the new tags for the low pt electron regression.

@mandrenguyen

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport plan for 14_1_X meant for the 2023 UPC PbPb rereco.

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 31, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46562/42444

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • RecoEcal/EgammaClusterProducers (reconstruction)
  • RecoEgamma/EgammaElectronProducers (reconstruction)
  • RecoEgamma/EgammaTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @jainshilpi, @lgray, @missirol, @ram1123, @rchatter, @rovere, @sameasy, @sobhatta, @thomreis, @valsdav, @varuns23, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a39ad/42512/summary.html
COMMIT: 0aa2b12
CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals

  • 5.15.1_TTbarFS/step1_TTbarFS.log
  • 4.534.53_RunPhoton2012B/step3_RunPhoton2012B.log
  • 4.224.22_RunCosmics2011A/step3_RunCosmics2011A.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
  • 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
  • 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 7 sec (ended on Thu Oct 31 14:50:10 2024) - exit: 256

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 6 sec (ended on Thu Oct 31 14:50:12 2024) - exit: 256

----- Begin Fatal Exception 31-Oct-2024 14:50:16 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py
Exception Message:
 unknown python problem occurred.
TypeError: eleRegs does not already exist, so it can only be set to a CMS python configuration type

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(319): __raiseBadSetAttr
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(771): _modifyParametersFromDict
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1063): clone
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/CMSSW_14_2_X_2024-10-30-2300/src/RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectrons_cfi.py(43): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/python/producersLayer1/lowPtElectronProducer_cff.py(69): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/python/producersLayer1/patCandidates_cff.py(4): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(762): load
  /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py(11): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46562/42466

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

Pull request #46562 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

@stahlleiton stahlleiton mentioned this pull request Nov 1, 2024
Closed
@stahlleiton stahlleiton changed the title Update the egamma regression for UPC PbPb Update the egamma regression for 2023 UPC PbPb rereco Nov 2, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46562/42487

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

Pull request #46562 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a39ad/42570/summary.html
COMMIT: 2258ac8
CMSSW: CMSSW_14_2_X_2024-11-03-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46562/42570/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 141.901141.901_RunUPC2023/step2_RunUPC2023.log

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569567
  • DQMHistoTests: Total failures: 391
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3569156
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 4, 2024

@stahlleiton it seems like the change is braeking the DQM offline sequence:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a39ad/42570/runTheMatrixINPUT-results/141.901_RunUPC2023/step2_RunUPC2023.log

@stahlleiton
Copy link
Contributor Author

stahlleiton commented Nov 4, 2024 •
edited
Loading

@stahlleiton it seems like the change is braeking the DQM offline sequence:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a39ad/42570/runTheMatrixINPUT-results/141.901_RunUPC2023/step2_RunUPC2023.log

The error is due to missing tags (the low pt Gsf electron ones) which are currently not yet added in a global tag. I will convert this PR to a draft until the new global tag is ready

@stahlleiton stahlleiton marked this pull request as draft November 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved orp-pending pending-signatures reconstruction-pending tests-rejected
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
3 participants
@stahlleiton @cmsbuild @jfernan2