-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate dictionary definition in DataFormats/L1Trigger #45554
Conversation
l1t::TkTripletWordCollection is a type alias for std::vector<l1t::TkTripletWord>.
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45554/41035 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
type -changes-dataformats |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Comparison SummarySummary:
|
Comparison failures are related to #39803, 2500.245 failure occurs in IBs as well (and should now be fixed). |
ignore test-rejected with ib-failure |
ignore tests-rejected with ib-failure |
+l1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The
l1t::TkTripletWordCollection
is a type alias forstd::vector<l1t::TkTripletWord>
whose dictionary is defined two lines above. Found with #45423 (comment)Resolves cms-sw/framework-team#964
PR validation:
Code compiles, and the to-be-added
edmDumpClassVersion
succeeds to process theclasses_def.xml
files.