Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dictionary definition in DataFormats/L1Trigger #45554

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

makortel
Copy link
Contributor

PR description:

The l1t::TkTripletWordCollection is a type alias for std::vector<l1t::TkTripletWord> whose dictionary is defined two lines above. Found with #45423 (comment)

Resolves cms-sw/framework-team#964

PR validation:

Code compiles, and the to-be-added edmDumpClassVersion succeeds to process the classes_def.xml files.

l1t::TkTripletWordCollection is a type alias for std::vector<l1t::TkTripletWord>.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/L1Trigger (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@dinyar, @eyigitba, @kreczko, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

type -changes-dataformats

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-832bf7/40586/summary.html
COMMIT: fe966d3
CMSSW: CMSSW_14_1_X_2024-07-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45554/40586/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2500.2452500.245_hcalDPGCalibNANO140Xrun3/step2_hcalDPGCalibNANO140Xrun3.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 85 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3325254
  • DQMHistoTests: Total failures: 2461
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3322773
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Comparison failures are related to #39803, 2500.245 failure occurs in IBs as well (and should now be fixed).

@makortel
Copy link
Contributor Author

ignore test-rejected with ib-failure

@makortel
Copy link
Contributor Author

ignore tests-rejected with ib-failure

@aloeliger
Copy link
Contributor

+l1

  • technical PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ba2fbc5 into cms-sw:master Jul 31, 2024
10 of 11 checks passed
@makortel makortel deleted the fixDictionariesL1Trigger branch July 31, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate dictionary definition in DataFormats/L1Trigger
4 participants