-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant dictionary definition in DataFormats/HGCRecHit #45551
Conversation
The equivalent "<class name="edm::SortedCollection<HGCRecHit,edm::StrictWeakOrdering<HGCRecHit> >"/>" is already defined above.
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45551/41033 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
type -changes-dataformats |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Comparison SummarySummary:
|
ignore tests-rejected with ib-failure |
+Upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will be automatically merged. |
PR description:
The equivalent
<class name="edm::SortedCollection<HGCRecHit,edm::StrictWeakOrdering<HGCRecHit> >"/>
is already defined above. This duplication was (I'd say accidentally) found in #45423 (comment) .Resolves cms-sw/framework-team#962
PR validation:
Code compiles, and the to-be-added
edmDumpClassVersion
succeeds to process theclasses_def.xml
files.