-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark dictionaries defined in OnlineDB/EcalCondDB as transient #45545
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45545/41021 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
type -changes-dataformats |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Comparison SummarySummary:
|
Failure in 2500.245 was in opening a file over xrootd. |
ignore tests-rejected with ib-failure |
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The
OnlineDB/EcalCondDB
package is not a data format package, and from the history (#29240) it seems the dictionaries were added in order to use them in PyROOT scripts. Found in #45423 (comment)Resolves cms-sw/framework-team#960
PR validation:
Code compiles, and the to-be-added
edmDumpClassVersion
succeeds to process theclasses_def.xml
.