Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changes-dataformats label if PR touches classes_def.xml #2290

Merged
merged 2 commits into from
Jul 10, 2024
Merged

add changes-dataformats label if PR touches classes_def.xml #2290

merged 2 commits into from
Jul 10, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jul 10, 2024 •
edited
Loading

See #2245 for details

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2290 was updated.

@smuzaffar
Copy link
Contributor Author

looks good , tested on cms-sw/cmssw#45420

@smuzaffar smuzaffar merged commit 1553625 into master Jul 10, 2024
3 of 4 checks passed
@smuzaffar smuzaffar mentioned this pull request Jul 10, 2024
Open
@smuzaffar smuzaffar deleted the changes-dataformats-classes_def branch September 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild