Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Local energy conservation loss #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oviazlo
Copy link
Contributor

@oviazlo oviazlo commented Jan 14, 2022

The first prototype of the function to calculate local energy conservation loss. To discuss.

@jkiesele
Copy link
Contributor

Thanks. In the end we'd need to put it in another file, together with other losses maybe; as I am trying to clean up a bit.
But this can be done even after the final PR is merged, since now it's quite useful to have it separate :)

I just had a quick look, but I am getting more and more the feeling that we should save the deposited true energy directly in the dataset - would that help you?

@oviazlo
Copy link
Contributor Author

oviazlo commented Jan 14, 2022

Hi @jkiesele. I rewrote the function. I hope this time I got everything correct. I was inspecting the output of the function and was comparing it with ediff calculated in LossLayers.py:
ediff = (t_energy - pred_energy*dep_energies)/tf.sqrt(t_energy+1e-3)
Both matrices were of a similar order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants