-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow gm fly command #558
base: master
Are you sure you want to change the base?
Allow gm fly command #558
Conversation
Classic doesn't have Should we not implement something analogous to TBC's command?
|
Client doesnt fly in vanilla afaik. The packet doesnt exist. Have you actually tried this? :D |
yes I have, the only issue is if you jump, that's why I put that warning message. We do have it working in SPP |
@cpevors Vanilla has no concept of flying, that was a brand-new addition with TBC. Vanilla has swimming, which is analogous to flying, but in vanilla swimming you could jump underwater. They hadn't remapped jumping to "ascend" yet. |
The more you know. Appreciate the insights, everyone! |
Vmangos has flying for ages, ofc it works |
But not sure if changed here are enough for it |
In hindsight, I think VMaNGOS has a version of flying that also cancels on 'jump,' though. From VMaNGOS:
|
ouch, I missed some extra code, should be fine now |
In order to make it work you need to do more changes |
@@ -12259,7 +12259,16 @@ void Unit::SetSwim(bool enable) | |||
|
|||
void Unit::SetCanFly(bool enable) | |||
{ | |||
// TBC+ | |||
if (enable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code can be now as a result be called for non player entities. Your PR aims to add it for GM players, for anyone else due to shenanigans of someone trying to debug this, this is not good to have. Amend it to only be strictly callable for player pls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gm fly on command is for target or self
If I understand it correctly and has a similar issue like knockback in tbc, you would have to actually check jump packet and re-add flying moveflag forcibly every time that happens for this to work. Anyone can feel free to correct me. |
🍰 Pullrequest
Allow gm fly command, I believe it is very useful for debugging purposes.