-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the musl-g++ issue fix in the README.md file. #150
Open
iddm
wants to merge
2
commits into
clux:main
Choose a base branch
from
iddm:explain-musl-g++-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,6 +165,38 @@ extern crate openssl; | |
|
||
This is true even if you connect without `sslmode=require`. | ||
|
||
### ZeroMQ (ZMQ), unrar and some other crates issues with musl-g++ | ||
|
||
Sometimes, when building Rust projects with the musl environment, one may observe an error: | ||
|
||
``` | ||
#10 365.1 Running `/volume/target/release/build/zmq-sys-5a9c7df2068dc61d/build-script-main` | ||
#10 365.1 The following warnings were emitted during compilation: | ||
#10 365.1 | ||
#10 365.1 warning: [email protected]: Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `musl-g++` installed? | ||
#10 365.1 | ||
#10 365.1 error: failed to run custom build command for `zmq-sys v0.12.0` | ||
#10 365.2 | ||
#10 365.2 Caused by: | ||
#10 365.2 process didn't exit successfully: `/volume/target/release/build/zmq-sys-5a9c7df2068dc61d/build-script-main` (exit status: 1) | ||
``` | ||
|
||
To fix it, simply in your Dockerfile, before building, force the OS to use the `/usr/bin/musl-g++` instead of `/usr/bin/g++`. For example: | ||
|
||
``` | ||
# Stage 1: Build the Rust executable | ||
FROM clux/muslrust as builder | ||
|
||
# Copy the source code into the container | ||
COPY . . | ||
|
||
# Build the statically-linked binary | ||
RUN chown 777 -R `pwd` && \ | ||
chown -R $(id -u) . && \ | ||
ln -s /usr/bin/g++ /usr/bin/musl-g++ && \ | ||
cargp build --target=x86_64-unknown-linux-musl | ||
``` | ||
|
||
### Filesystem permissions on local builds | ||
|
||
When building locally, the permissions of the musl parts of the `./target` artifacts dir will be owned by `root` and requires `sudo rm -rf target/` to clear. This is an [intended](https://github.com/clux/muslrust/issues/65) complexity tradeoff with user builds. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There's a typo in
cargo
thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! Should be fixed!