Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image build dependency #639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KubeKyrie
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #None

Special notes for your reviewer:
Add image build dependency so that we can directly make image-apiserver when builder not exists.

Does this PR introduce a user-facing change?:

Add image build dependency

@clusterpedia-bot
Copy link

Hi @KubeKyrie,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/feature New feature label Jan 7, 2024
@Iceber
Copy link
Member

Iceber commented Jan 8, 2024

you could use make build-image-apiserver

clusterpedia/Makefile

Lines 95 to 100 in b4117dd

build-image-%:
GOARCH=$(HOSTARCH) $(MAKE) image-builder
$(MAKE) $(subst build-,,$@)
image-apiserver:
docker buildx build \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants