remove skip native

cloudwego · Sep 10, 2024 · 6b60f32 · 6b60f32
1 parent cadacd3
commit 6b60f32
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 52 deletions.
diff --git a/thrift/binary_skip.go b/thrift/binary_skip.go
@@ -50,11 +50,6 @@ func TypeSize(t Type) int {
 
 // Skip skips over the value for the given type.
 func (p *BinaryProtocol) Skip(fieldType Type, useNative bool) (err error) {
-	if false {
-		// TODO: rm the skip native in the future, no longer use.
-		// The pure go implementation is better than c
-		return p.SkipNative(fieldType, MaxSkipDepth)
-	}
 	return p.SkipGo(fieldType, MaxSkipDepth)
 }
 

diff --git a/thrift/binary_skip_amd64.go b/thrift/binary_skip_amd64.go
diff --git a/thrift/binary_skip_other.go b/thrift/binary_skip_other.go
@@ -1,5 +1,3 @@
-//go:build !amd64
-
 /**
  * Copyright 2024 cloudwego Inc.
  *