Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add display contents to runtime drawer wrapper #2957

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

jkuelz
Copy link
Member

@jkuelz jkuelz commented Oct 30, 2024

Description

Prep for a fix to make drawer content to extend full height.
This change has uncovered a few issues:

  1. Other components which used this wrapper were unintentionally affected by this change (see screenshot approval 40eb2153-dfbe-4dba-aa83-28f65c5474e1). This is being solved in chore: Fix code reuse between app layout and alert/flashbar runtime API #2963, which needs to be merged before this one, and this will require a rebase.
    Screenshot 2024-10-31 at 12 33 49 PM
  2. Webdriver is seemingly unable to access text that are direct children of display: contents, when a parent has overflow: hidden applied (which is the case for drawers).
<div id="one" style={{overflow: 'hidden'}}>
    <div>Ok</div> // findable
    <div style={{display: 'contents'}}>Does not work</div> // not findable
    <div style={{display: 'contents'}}>
        <span>Also works</span> // findable
    </div>
</div>
<div id="two" style={{display: 'contents'}}>  // findable
    This works
</div>

Both of these issues were originally solved another way #2924, which presented other issues mentioned there.
Since then, it has been decided that these failed tests is a bug in Webdriver, not our tests or implementation. To make these tests pass, two options were presented:

  • Option 1 Updating the dev page (ended up going in this direction)
  • Option 2 Updating the test itself

Related links, issue #, if available: n/a

How has this been tested?

Ran through dev pipeline.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (ba58915) to head (c643c42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2957    +/-   ##
========================================
  Coverage   96.25%   96.25%            
========================================
  Files         768      768            
  Lines       21750    21750            
  Branches     7434     7034   -400     
========================================
  Hits        20935    20935            
  Misses        807      807            
  Partials        8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good I will approve and merge this when the prerequisite is merged: #2963

@just-boris just-boris added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 13b63b8 Nov 1, 2024
37 checks passed
@just-boris just-boris deleted the jkuelz-drawer-fix-1 branch November 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants