-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add display contents to runtime drawer wrapper #2957
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
========================================
Coverage 96.25% 96.25%
========================================
Files 768 768
Lines 21750 21750
Branches 7434 7034 -400
========================================
Hits 20935 20935
Misses 807 807
Partials 8 8 ☔ View full report in Codecov by Sentry. |
df2ecde
to
5b15655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good I will approve and merge this when the prerequisite is merged: #2963
5b15655
to
b70a17c
Compare
b70a17c
to
c643c42
Compare
Description
Prep for a fix to make drawer content to extend full height.
This change has uncovered a few issues:
display: contents
, when a parent hasoverflow: hidden
applied (which is the case for drawers).Both of these issues were originally solved another way #2924, which presented other issues mentioned there.
Since then, it has been decided that these failed tests is a bug in Webdriver, not our tests or implementation. To make these tests pass, two options were presented:
Related links, issue #, if available: n/a
How has this been tested?
Ran through dev pipeline.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.