Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add yellow value to status indicator colorOverride prop #1682

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jperals
Copy link
Member

@jperals jperals commented Oct 24, 2023

Description

Fixes #1643.

Since warning yellow was added to the system in #1340, it only makes sense that this color can be used as color override for status indicators.

How has this been tested?

  • Added permutation to existing permutations page, verified the result visually
  • Verified that the BackstopJS failures are as expected
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a86eadc) 94.20% compared to head (37a4fb1) 94.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         650      650           
  Lines       17539    17539           
  Branches     5776     5776           
=======================================
  Hits        16522    16522           
  Misses        948      948           
  Partials       69       69           
Files Coverage Δ
src/status-indicator/internal.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals jperals marked this pull request as ready for review October 24, 2023 07:27
@jperals jperals requested a review from a team as a code owner October 24, 2023 07:27
@jperals jperals requested review from timogasda and removed request for a team October 24, 2023 07:27
@jperals jperals merged commit 3d3418e into main Oct 24, 2023
41 of 42 checks passed
@jperals jperals deleted the feat/status-indicator-colorOverride-yellow branch October 24, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: StatusIndicator - Support yellow colorOverride prop
2 participants