-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support iframes in container media content #1487
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
+ Coverage 93.81% 93.93% +0.12%
==========================================
Files 640 642 +2
Lines 17273 17276 +3
Branches 5683 5682 -1
==========================================
+ Hits 16204 16228 +24
+ Misses 996 976 -20
+ Partials 73 72 -1
☔ View full report in Codecov by Sentry. |
Could you add an iframe example to dev page? We cannot render external resources, but I think we can get an inline content like |
Description
We'd like to support automatically scaling the
<iframe>
element as a direct child of the media container. For youtube embeds and such.Related links, issue #, if available: AWSUI-22100
How has this been tested?
There are screenshot tests for this styling on images already.
Don't know if it's worth adding iframe-specific screenshot tests and scenarios for justiframes now have custom styling (removing the border), so added some permutations.width: 100%; height: 100%
.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.