chore: Add runtime actions discovery to alert and flashbar #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
=======================================
Coverage 93.57% 93.58%
=======================================
Files 631 636 +5
Lines 16897 16934 +37
Branches 5583 5581 -2
=======================================
+ Hits 15812 15848 +36
- Misses 1013 1014 +1
Partials 72 72
☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
feat-discovered-actions
branch
3 times, most recently
from
5aa2832
to
2cf84a6
Compare
just-boris
commented
Aug 10, 2023
|
|
||
| @use '../../internal/styles/tokens' as awsui; | ||
|
|
||
| .root { |
There was a problem hiding this comment.
This is not a space between component, because runtime plugins require rendering an empty <div> as a mount point and this breaks :empty styling.
In this custom implementation, the wrapper nodes are deduplicated and :empty works again
just-boris
commented
Aug 10, 2023
Comment on lines
-21
to
-24
| if (this.updateTimeout) { | ||
| clearTimeout(this.updateTimeout); | ||
| } | ||
| this.updateTimeout = setTimeout(() => { |
There was a problem hiding this comment.
I have figured that this timeout is basically a debounce implementation and I can reuse our existing one
just-boris
force-pushed
the
feat-discovered-actions
branch
from
2cf84a6
to
f85db70
Compare
gethinwebster
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement new runtime API
Related links, issue #, if available: n/a
How has this been tested?
Added unit tests and dev pages for screenshot tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.