feat: Provide accessible name to menu in button-dropdown #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 639 639
Lines 17228 17230 +2
Branches 5664 5665 +1
=======================================
+ Hits 16159 16161 +2
Misses 996 996
Partials 73 73
☔ View full report in Codecov by Sentry. |
Al-Dani
force-pushed
the
dropdown-auto-label
branch
from
85600c7
to
1336d3d
Compare
pan-kot
reviewed
Aug 3, 2023
| @@ -259,7 +263,8 @@ const InternalButtonDropdown = React.forwardRef( | |||
| position="static" | |||
| role="menu" | |||
| decreaseTopMargin={true} | |||
| ariaLabelledby={hasHeader ? headerId : undefined} | |||
| ariaLabel={ariaLabel} | |||
| ariaLabelledby={hasHeader ? headerId : shouldLabelWithTrigger ? triggerId : undefined} | |||
There was a problem hiding this comment.
What is header and why trigger ARIA label is preferred over the header?
There was a problem hiding this comment.
header is a combination of title and description, these properties are available only internally and can be used with variant: 'navigation' inside TopNavigation.
Priorities are the following:
- if there is a header inside dropdown, than it is used to label menu list
- else if we have aria-label - use it
- else if the variant is not
iconorinline-icon- label by trigger text
In case of a split button variant I assume there will be an aria-label, because trigger itself is an icon and we can't auto-label dropdown with it
pan-kot
reviewed
Aug 3, 2023
Al-Dani
force-pushed
the
dropdown-auto-label
branch
from
1336d3d
to
3cc113e
Compare
Al-Dani
force-pushed
the
dropdown-auto-label
branch
from
3cc113e
to
8205d48
Compare
Al-Dani
force-pushed
the
dropdown-auto-label
branch
from
8205d48
to
50d9bdd
Compare
pan-kot
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Items with role="menu" need an accessible name. We will re-use trigger button label for normal and primary variants or aria-label if it is provided.
Related links, issue #, if available: AWSUI-21666
How has this been tested?
New unit tests added
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.