-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Table grid navigation (no integration) #1389
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 93.56% 93.70% +0.14%
==========================================
Files 633 636 +3
Lines 16901 17161 +260
Branches 5581 5658 +77
==========================================
+ Hits 15813 16081 +268
+ Misses 1016 1008 -8
Partials 72 72
☔ View full report in Codecov by Sentry. |
3d2956a
to
74c8ca9
Compare
This reverts commit b7fd4ac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment on this functionality: can we document somewhere accessible to customers (perhaps on the website?) the expected behavior/interactions? From what I remember from the last call, there were quite a few edge cases/tradeoffs related to interactive elements in cells, and the standards/guidelines aren't entirely clear, so it would be good to write down how and why the component/feature behaves.
(This has been a regular ask from customers for existing functionality, and for something complex like this I think it's even more valuable)
Sure, that makes total sense - I will add the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a feat
? As far as I see there's no public changes so far, so we probably don't e.g. want this in the changelog
@gethinwebster, I added the doc explaining the current behaviour. I am expecting certain changes to come as result of further discussions, bug bashes, integration with the table, and the API proposal - I will make sure to reflect those changes in the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
Added new navigation mechanism for table grids. For now the change is tested on a custom table and only minimal changes to the official table component are made so that everything can be tested and merged incrementally.
Eventually the new navigation will replace the current one for editable tables (
use-table-focus-navigation.ts
) and for selection column (useSelection.ts:useFocusMove
) and will be offered for all tables with a dedicated API.How has this been tested?
New unit and integration tests to cover the change. Screenshot tests.
The behaviour can be manually tested in the new test page.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.