feat: Improve wrapping behavior of actions in header #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 642 642
Lines 17334 17334
Branches 5695 5695
=======================================
Hits 16291 16291
Misses 973 973
Partials 70 70
☔ View full report in Codecov by Sentry. |
timogasda
force-pushed
the
gasda/header-responsiveness
branch
from
12995c9
to
6706386
Compare
timogasda
force-pushed
the
gasda/header-responsiveness
branch
from
70bc4bb
to
515e8df
Compare
timogasda
force-pushed
the
gasda/header-responsiveness
branch
from
2f61287
to
2cbca12
Compare
timogasda
force-pushed
the
gasda/header-responsiveness
branch
from
ab35bf8
to
4785919
Compare
timogasda
changed the title
timogasda
force-pushed
the
gasda/header-responsiveness
branch
from
197a22b
to
f642687
Compare
timogasda
force-pushed
the
gasda/header-responsiveness
branch
from
f642687
to
e00f4bf
Compare
avinashbot
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Changes look good at first glance, I'll leave checking pixel changes and screenshot tests to you, have fun!
gap on flex is not supported on Safari 14.0, but given that we're on the cusp of a new Safari release and this won't block anything, I'm okay with it, after a double-check with the dev team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The header component contains three main parts: a mandatory title, as well as optional description and actions. The actions are displayed in the top right corner of the header, but currently they wrap below the title and description very early. This takes up unnecessary vertical space, especially when the header contains a description text.
This change swaps the order of elements and reorganizes them so that the title and actions now build one block, followed by the description block.
More details:
2m0RALROKrfORelated links, issue #, if available: AWSUI-19066
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.