chore: Fix flaky oscillating resize test #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
commented
Jul 26, 2023
| @@ -83,7 +79,7 @@ test( | |||
| }) | |||
| ); | |||
|
|
|||
| test( | |||
| test.each([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20])( | |||
There was a problem hiding this comment.
Running the test 20 times to ensure it is stable. I will remove it before merging.
just-boris
previously approved these changes
Jul 26, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 623 623
Lines 16764 16764
Branches 5547 5547
=======================================
Hits 15669 15669
Misses 1022 1022
Partials 73 73 ☔ View full report in Codecov by Sentry. |
avinashbot
approved these changes
Jul 26, 2023
jperals
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed tests by using the counter instead of the resize observer entry which caused issues with chromedriver
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.