-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Render Visual Refresh background height in sync with content #1344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efd419e.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 623 624 +1
Lines 16731 16743 +12
Branches 5527 5530 +3
=======================================
+ Hits 15637 15649 +12
Misses 1021 1021
Partials 73 73
☔ View full report in Codecov by Sentry. |
Working on #1331 as our preferred option. Will close this one once that one is merged. |
Closing in favor of #1331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative approach to #1331, a bit more orthodox (follows guidance from facebook/react#24331) but with performance impact.
As a long-term fix, we want to refactor app layout so that resize observer calls are not necessary to keep the content and the background in sync.
Ticket: AWSUI-21410
How has this been tested?
Lighthouse tests indicate the following performance impact in React 18 (average of 2 table views, 3 runs each):
Performance recordings in tools indicate an average increase of time from interaction to next paint of 28.4ms (from 153.2 to 181.6ms, +18.53%) compared to #1331 (tried 5 times each)
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.