fix a11y for selection control

cloudscape-design · Aug 28, 2023 · ca6157d · ca6157d
1 parent 750b43d
commit ca6157d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 17 deletions.
diff --git a/src/__a11y__/run-a11y-tests.ts b/src/__a11y__/run-a11y-tests.ts
@@ -24,21 +24,19 @@ function urlFormatter(inputUrl: string, theme: Theme, mode: Mode) {
 
 export default function runA11yTests(theme: Theme, mode: Mode, skip: string[] = []) {
   describe(`A11y checks for ${mode} ${theme}`, () => {
-    findAllPages()
-      .filter(url => url.includes('grid-navigation'))
-      .forEach(inputUrl => {
-        const skipPages = [
-          ...skip,
-          'theming/tokens',
-          // this page intentionally has issues to test the helper
-          'undefined-texts',
-        ];
-        const testFunction = skipPages.includes(inputUrl) ? test.skip : test;
-        const url = urlFormatter(inputUrl, theme, mode);
-        testFunction(
-          url,
-          setupTest(url, page => page.assertNoAxeViolations())
-        );
-      });
+    findAllPages().forEach(inputUrl => {
+      const skipPages = [
+        ...skip,
+        'theming/tokens',
+        // this page intentionally has issues to test the helper
+        'undefined-texts',
+      ];
+      const testFunction = skipPages.includes(inputUrl) ? test.skip : test;
+      const url = urlFormatter(inputUrl, theme, mode);
+      testFunction(
+        url,
+        setupTest(url, page => page.assertNoAxeViolations())
+      );
+    });
   });
 }
diff --git a/src/table/header-cell/index.tsx b/src/table/header-cell/index.tsx
@@ -108,7 +108,7 @@ export function TableHeaderCell<ItemType>({
           [styles['header-cell-fake-focus']]: focusedComponent === `sorting-control-${String(columnId)}`,
         })}
         aria-label={
-          column.ariaLabel
+          column.ariaLabel && !sortingDisabled
             ? column.ariaLabel({
                 sorted: sorted,
                 descending: sorted && !!sortingDescending,