Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation command in readme #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Mar 15, 2023

While attempting to install memory calculator with the recent version of Go (specifically 1.20.2) I was greeted with the following:

$ go get -v github.com/cloudfoundry/java-buildpack-memory-calculator
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

This PR updates the install command according to the guidance from the link in the error message from above:

$ go install github.com/cloudfoundry/java-buildpack-memory-calculator@latest
go: downloading github.com/cloudfoundry/java-buildpack-memory-calculator v0.0.0-20190501234420-5148668b0710
go: downloading github.com/spf13/pflag v1.0.3

@linux-foundation-easycla
Copy link

CLA Not Signed

@vpavic
Copy link
Contributor Author

vpavic commented May 31, 2024

Anything preventing this from getting review and hopefully merged?

If it's the CLA, IMO this is a trivial change (and one that does not touch the code) that would fall into the obvious fix category under the Pivotal CLA. Note that similar changes have been merged before without the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant