Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): merge to master #4800

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Conversation

piggggggggy
Copy link
Member

To Reviewers

  • Skip (style, chore, ci, minor refactoring, etc.)
  • Need discussion
  • Not that difficult
  • Approved feature branch merge to master

Description

SSIA

Things to Talk About

yuda110 and others added 8 commits September 30, 2024 16:02
* fix: fix starred menu bug in dashboard LSB

Signed-off-by: yuda <[email protected]>

* fix: filter project dashboard "only share by admin"

Signed-off-by: yuda <[email protected]>

* chore: fix invalid bug

Signed-off-by: yuda <[email protected]>

* chore: fix tooltip issue

Signed-off-by: yuda <[email protected]>

* refactor: apply cancel token to widget/load

Signed-off-by: yuda <[email protected]>

* chore: show 'No Label' text

Signed-off-by: yuda <[email protected]>

---------

Signed-off-by: yuda <[email protected]>
Signed-off-by: samuel.park <[email protected]>
feat: apply cancellable fetcher to table widget
* fix: fix shared project dashboard bug

Signed-off-by: yuda <[email protected]>

* fix: fix filters issue

Signed-off-by: yuda <[email protected]>

---------

Signed-off-by: yuda <[email protected]>
…data enums to cost-analysis page (#4798)

* fix: solve saved preset filter item bug

Signed-off-by: samuel.park <[email protected]>

* fix: apply cost-data-source metadata enums to cost-analysis page

Signed-off-by: samuel.park <[email protected]>

---------

Signed-off-by: samuel.park <[email protected]>
* chore: fix minor style bug

Signed-off-by: yuda <[email protected]>

* fix: set order to table data field

Signed-off-by: yuda <[email protected]>

* fix: fix dashboard move modal bug

Signed-off-by: yuda <[email protected]>

* fix: fix delete modal bug

Signed-off-by: yuda <[email protected]>

* chore: update language

Signed-off-by: yuda <[email protected]>

---------

Signed-off-by: yuda <[email protected]>
@piggggggggy piggggggggy merged commit 3d4bbd3 into master Sep 30, 2024
2 of 3 checks passed
Copy link
Contributor

⚠️ @piggggggggy the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants