Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workers] add wrangler v3 dependency info for updating #10241

Closed
wants to merge 1 commit into from

Conversation

admah
Copy link
Contributor

@admah admah commented Aug 7, 2023

Added note about better-sqlite3 dependency for Wrangler v3 per #9463

For more information: cloudflare/workers-sdk#3531

@admah admah requested review from GregBrimble, WalshyDev and a team as code owners August 7, 2023 14:04
@github-actions github-actions bot added size/xs product:workers Related to Workers product labels Aug 7, 2023
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d80d38f
Status: ✅  Deploy successful!
Preview URL: https://e2422330.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://admah-addv3deps.cloudflare-docs-7ou.pages.dev

View logs

@deadlypants1973
Copy link
Contributor

Does this solve #10230 ?

Copy link
Contributor

@deadlypants1973 deadlypants1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCX

@@ -14,6 +14,10 @@ If you tried to update to Wrangler v3 prior to v3.3, you may have experienced so

{{</Aside>}}

## Additional dependencies

As a result of updating the Miniflare storage system, `better-sqlite3` is now a dependency of Wrangler v3. If you do not have this installed, view the package's [installation instructions](https://www.npmjs.com/package/better-sqlite3) on npm for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As a result of updating the Miniflare storage system, `better-sqlite3` is now a dependency of Wrangler v3. If you do not have this installed, view the package's [installation instructions](https://www.npmjs.com/package/better-sqlite3) on npm for more information.
As a result of updating the Miniflare storage system, `better-sqlite3` is now a dependency of Wrangler v3. If you do not have `better-sqlite3` installed, view the [`better-sqlite3` installation instructions](https://www.npmjs.com/package/better-sqlite3) on npm for more information.

mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 14, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Sep 5, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Sep 5, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes #599

Fixes cloudflare/workers-sdk#3423
Fixes cloudflare/workers-sdk#3449
Fixes cloudflare/workers-sdk#3531
Fixes cloudflare/workers-sdk#3534
Fixes cloudflare/workers-sdk#3708
Fixes cloudflare/workers-sdk#3746

Closes cloudflare/cloudflare-docs#10241
@lrapoport-cf
Copy link
Contributor

following cloudflare/miniflare#656, this docs update is no longer needed 👍

mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Oct 31, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes cloudflare/miniflare#599

Fixes #3423
Fixes #3449
Fixes #3531
Fixes #3534
Fixes #3708
Fixes #3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Nov 1, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes cloudflare/miniflare#599

Fixes #3423
Fixes #3449
Fixes #3531
Fixes #3534
Fixes #3708
Fixes #3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Nov 1, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes cloudflare/miniflare#599

Fixes #3423
Fixes #3449
Fixes #3531
Fixes #3534
Fixes #3708
Fixes #3746

Closes cloudflare/cloudflare-docs#10241
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Nov 1, 2023
...and move dependencies only used in Workers to `devDependencies`.
They're bundled in with the Worker code, so don't need to be
installed again. Importantly, this change removes `better-sqlite3`,
meaning Miniflare no longer has any native dependencies other than
`workerd`.

Fixes cloudflare/miniflare#599

Fixes #3423
Fixes #3449
Fixes #3531
Fixes #3534
Fixes #3708
Fixes #3746

Closes cloudflare/cloudflare-docs#10241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants