-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workers] add wrangler v3 dependency info for updating #10241
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Files with changes (up to 15) |
WalshyDev
approved these changes
Aug 7, 2023
Does this solve #10230 ? |
deadlypants1973
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCX
@@ -14,6 +14,10 @@ If you tried to update to Wrangler v3 prior to v3.3, you may have experienced so | |||
|
|||
{{</Aside>}} | |||
|
|||
## Additional dependencies | |||
|
|||
As a result of updating the Miniflare storage system, `better-sqlite3` is now a dependency of Wrangler v3. If you do not have this installed, view the package's [installation instructions](https://www.npmjs.com/package/better-sqlite3) on npm for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
As a result of updating the Miniflare storage system, `better-sqlite3` is now a dependency of Wrangler v3. If you do not have this installed, view the package's [installation instructions](https://www.npmjs.com/package/better-sqlite3) on npm for more information. | |
As a result of updating the Miniflare storage system, `better-sqlite3` is now a dependency of Wrangler v3. If you do not have `better-sqlite3` installed, view the [`better-sqlite3` installation instructions](https://www.npmjs.com/package/better-sqlite3) on npm for more information. |
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 14, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Aug 17, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Sep 5, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Sep 5, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes #599 Fixes cloudflare/workers-sdk#3423 Fixes cloudflare/workers-sdk#3449 Fixes cloudflare/workers-sdk#3531 Fixes cloudflare/workers-sdk#3534 Fixes cloudflare/workers-sdk#3708 Fixes cloudflare/workers-sdk#3746 Closes cloudflare/cloudflare-docs#10241
following cloudflare/miniflare#656, this docs update is no longer needed 👍 |
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Oct 31, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes cloudflare/miniflare#599 Fixes #3423 Fixes #3449 Fixes #3531 Fixes #3534 Fixes #3708 Fixes #3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes cloudflare/miniflare#599 Fixes #3423 Fixes #3449 Fixes #3531 Fixes #3534 Fixes #3708 Fixes #3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes cloudflare/miniflare#599 Fixes #3423 Fixes #3449 Fixes #3531 Fixes #3534 Fixes #3708 Fixes #3746 Closes cloudflare/cloudflare-docs#10241
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
...and move dependencies only used in Workers to `devDependencies`. They're bundled in with the Worker code, so don't need to be installed again. Importantly, this change removes `better-sqlite3`, meaning Miniflare no longer has any native dependencies other than `workerd`. Fixes cloudflare/miniflare#599 Fixes #3423 Fixes #3449 Fixes #3531 Fixes #3534 Fixes #3708 Fixes #3746 Closes cloudflare/cloudflare-docs#10241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about better-sqlite3 dependency for Wrangler v3 per #9463
For more information: cloudflare/workers-sdk#3531